Repository navigation
fix(bike-mount): align interface source default with manifest - #101
Merged
Merged
Conversation
The PARAM fallback for `interface` was "gopro", which is not even an option of the select (light | phone_tab); the manifest default is "light". The strap_mount dispatch already coerced anything else to "light", so geometry is unchanged, but the source literal now states the manifest default so a render that injects every declared parameter cannot drift from one that injects none (GOC-1 default-drift). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Aldo Ruiz Luna <aldo.ruiz.luna@gmail.com>
aldoruizluna
marked this pull request as ready for review
October 2, 2026 22:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
bike-mount/main.py:61— thePARAMfallback forinterfacenow equals the manifest default.interface"light""gopro""light"The trailing comment now lists the select's real options (
light | phone_tab).Direction and why
Source literal → manifest default. Studio always sends the manifest-resolved parameter set, so the manifest default is what users see.
"gopro"is not an option of this select at all, and the strap_mount dispatch (main.py:311) already coerced any other value to"light", so the default geometry does not change. Only the literal now says so.How this maps to GOC-1
GOC-1 (Digital Twins MES, Phase 2)
variables.jsonis only complete once yantra4d injects every declared parameter (RENDER_INJECT_FULL_PARAMS). A cartridge whose source fallback differs from its manifest default would change geometry for API callers that send{}when that flag flips. This PR removes thedefault-driftnote for this cartridge (hyperobjects-spec#30).Evidence
Run with hyperobjects-spec at
510efba(the #30 branch; CI pins3ff3736, which lacks the rule), CadQuery 2.8.0, OpenSCAD 2026.02.13, macOS:macOS green is not proof (AGENTS.md rule 4). CI's Linux render lane is the verdict, and it had not run when this was written.
No
verificationchange. One cartridge, one file.CI status (updated)
Linux CI on this head: manifest conformance (all cartridges): pass; render (cartridges changed in this PR) (bike-mount): pass; render scope (which cartridges changed): pass.
🤖 Generated with Claude Code