Repository navigation
fix(button): preserve precise dimensions across garment handoffs - #100
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com> Codex-Session: codex://threads/01a0e4e2-1f79-76c0-a2b4-290d72f04dbe Signed-off-by: Aldo Ruiz Luna <aldo.ruiz.luna@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fashion garment handoffs can specify valid button dimensions between this cartridge's coarse slider steps. Preserve those dimensions by refining thickness, hole diameter, hole spacing and dish-depth resolution, while retaining the existing bounds, integer ligne size, hole-count choices and single-body verification.
Add three bilingual presets covering the newly representable dimensions and document the contract: parameter resolution is not manufacturing accuracy, and unsupported modes or dimensions still fail closed. Only sew-through-button is changed.
Validation: the pinned spec verifier renders eight cases/six presets locally with zero failures, notes or skips (CadQuery only, no comparable parity pair). Native checks cover all 21 newly representable Fashion defaults, 14 unique parameter sets, with valid positive single-solid BReps and preserved supplied dimensions. The actual bridge accepts 139/302 defaults with the candidate contract versus 118/302 before, with no accepted handoffs lost. These are local checks; Linux CI and downstream Yantra/Fashion adoption remain required.
The new README links resolve. The whole-repository Markdown guard reports four pre-existing broken links outside this cartridge; this PR does not claim to repair them.