Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature
This PR addresses the issue/bug described in issue #9.
Checklist
For code PRs only:
Summary
This PR introduces an alternative method of parsing nodes, that preserves the original context (and most of the original formatting) of the document they were parsed from so they can be properly written back out to the same file(s) later.
Usage examples
Honestly, just read the codebase for now. I'll add proper documentation before merging this.
Testing
Lots of unit tests for the smaller components, the whole Document class is kinda just covered by three integration tests right now. More tests should be written before merging this.
Performance Impact
Makes the library bigger and adds an optional worse-performance way to do things without hurting the performance of the original approach. Not a big issue.