Skip to content

docs(readme): say the loop raises ModelError for unparseable tool calls - #37

Merged
folathecoder merged 1 commit into
lunarstack-co:mainfrom
bs-gitem:docs/readme-model-output-error
Nov 5, 2026
Merged

folathecoder merged 1 commit into
lunarstack-co:mainfrom
bs-gitem:docs/readme-model-output-error

Conversation

@bs-gitem

@bs-gitem bs-gitem commented Nov 5, 2026

Copy link
Copy Markdown

Fixes #21

What changed

The README's error table said the loop raises ModelOutputError for unparseable tool calls. It doesn't. The loop asks the model to fix the call, and if it keeps sending broken calls it raises ModelError. I changed that one row to match what the code actually does. The first sentence and Retryable column stayed the same.

ModelOutputTruncatedError already has its own row for calls cut off by the output limit, so I left that alone. REFERENCE.md doesn't repeat the claim. There's no CHANGELOG line, since this only changes docs wording.

How I tested it

  • I ran a scratch script using ScriptedModel with three turns of broken tool calls using { as the arguments. agent.run raised ModelError with the message "Model produced unparseable tool calls on 3 consecutive turns", not ModelOutputError.
  • uv run pytest tests/test_readme.py passes. I also changed the Retryable cell to yes to check if the test would catch it. It failed, so I changed it back.
  • ruff check, ruff format --check, and mypy pass. With one Windows test deselected, pytest reported 537 passed, 6 skipped.
  • test_parallel_timeout_keeps_other_results fails on my Windows machine, but it also fails on main before my change. The 0.01 s timeout might be related to Windows timing. I deselected it and left it unchanged.

AI helped with

Drafted and checked with Claude Code; the run and the output are mine.

Closes lunarstack-co#21

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@folathecoder folathecoder left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Can you optionally star the project to support?

@folathecoder
folathecoder merged commit bb895b8 into lunarstack-co:main Nov 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

README says ModelOutputError is raised for unparseable tool calls, but the loop raises ModelError

2 participants