Skip to content

fix(AllNovelFull): parse only the main novel list - #2653

Merged
rajarsheechatterjee merged 6 commits into
lnreader:masterfrom
D3ICIDE:allNovelFull
Oct 10, 2026
Merged

rajarsheechatterjee merged 6 commits into
lnreader:masterfrom
D3ICIDE:allNovelFull

Conversation

@D3ICIDE

@D3ICIDE D3ICIDE commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

This PR was initially for #2652 but it seems their issue is something else (couldn't replicate their issue). I fixed something else

readnovelfull multisrc targets any element which contains "archive" in its name. It works for most sites but AllNovelFull site has three elements with "archive" in its name (main content and side bars). This might have been creating blank cells in the app I'm not sure but scoping to the exact selectors fixed the blank cells issue

Checklist

  • Update version code if an existing plugin was modified
  • Test changes in Plugin Playground or the app
  • Reference related issues in the PR body (e.g. Closes #xyz)
  • Commit messages follow type(scope): description (e.g. feat(<generator>): add new source)

Copilot AI balanced review requested due to automatic review settings October 8, 2026 12:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@greptile-apps

greptile-apps Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[Medium risk] Adjusts novel list parsing logic for one plugin source.

The PR appears safe to merge; no actionable issues were found.

What we checked:

  • Other sources keep matching lists: Without listClass, the parser uses the same class checks as before and does not apply the new state restriction.

Summary

The PR limits AllNovelFull’s novel-list parsing to elements with the fwn-archive-main class, keeping sidebar lists out.

  • Adds an optional listClass setting while preserving the old matching behavior for other sources.
  • Increases AllNovelFull’s plugin version to 2.2.2.
  • No actionable issues were found.

Reviews (1) · Last reviewed commit: "cleanup" · Reviewed by Greptile

@rajarsheechatterjee
rajarsheechatterjee merged commit 184d968 into lnreader:master Oct 10, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants