Repository navigation
Preserve string bytes when stripping ANSI colors - #112
Open
mikamikasuki wants to merge 1 commit into
Open
mikamikasuki wants to merge 1 commit into
mikamikasuki wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
NoColorenabled, a string attribute containingbefore�aftercurrently renders askey=before. The ANSI filter stops atutf8.RuneError, including a valid U+FFFD character, and discards the rest of the text.Continue filtering by rune, but retain the original byte spans. This preserves replacement characters and malformed UTF-8 bytes while allowing the existing quoting code to render them correctly.
Added nine cases for replacement characters, malformed and incomplete UTF-8, colored values, attribute keys, and plain text. Eight fail on the original code.
Validation: full CI-style race tests with
faketimepass on Go 1.23 and 1.27;go vetand Staticcheck pass. A separate 325,185-case comparison withslog.TextHandlercovers values, keys, ANSI filtering, cached attributes, and group names.Prepared with AI assistance.