Repository navigation
feat(egress): add optional deploymentStrategy - #167
Merged
biglittlebigben merged 2 commits intoSep 17, 2026
Merged
Conversation
Egress rollouts can stall Pending under default RollingUpdate when replicaCount is 1 and pods are too large to surge onto tainted nodes. Render strategy only when deploymentStrategy is set, matching livekit-server. The empty default keeps current behavior. Bump the chart to 1.12.1. Signed-off-by: Tanish Desai <tanishdesai37@gmail.com>
Contributor
Author
|
@karlsonlee-livekit @tinalenguyen Can you please review it or redirect it to correct person. |
Contributor
Author
|
@biglittlebigben can you please take a look. |
| description: Egress is used by LiveKit to stream and record rooms. | ||
| type: application | ||
| version: 1.12.0 | ||
| version: 1.12.1 |
Contributor
There was a problem hiding this comment.
We want to keep the chart version in sync with the app version. That being said, both should be bumped to v1.14.1 anyway.
biglittlebigben
approved these changes
Sep 17, 2026
Contributor
|
Thanks! |
IngLP
added a commit
to IngLP/livekit-helm
that referenced
this pull request
Oct 9, 2026
Upstream PR livekit#167 left `appVersion: "v1.14.1` unterminated, so Helm cannot load the egress chart from upstream master. Temporary fork patch: drop it as soon as upstream fixes the line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
IngLP
added a commit
to IngLP/livekit-helm
that referenced
this pull request
Oct 9, 2026
Upstream's test.yaml passes chart directories where chart-testing expects their parents, so it stays green even on an unloadable chart (upstream livekit#167). Kept in its own file so that rebasing onto upstream never conflicts with it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
martin-mat
added a commit
to martin-mat/livekit-helm
that referenced
this pull request
Oct 16, 2026
livekit#167 left appVersion as "v1.14.1 without its closing quote, so the chart's Chart.yaml doesn't parse: helm lint and helm template fail with 'yaml: line 10: found unexpected end of stream', and the repository's ct lint --all fails for every pull request. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Martin Matyas <martin.matyas@tieto.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Egress rollouts can stall Pending under default RollingUpdate when replicaCount is 1 and pods are too large to surge onto tainted nodes.
Render strategy only when deploymentStrategy is set, matching livekit-server. The empty default keeps current behavior. Bump the chart to 1.12.1.