Skip to content

Reassess OAuth session rotation and its costs #22

Open

Description

@linkdata

Context

Issue #7 reproduced session fixation when an attacker planted a guest JaWS cookie in a victim browser and both requests appeared to come from the same client IP. OAuth login rotation was added in v1.4.0 to stop that pre-login cookie from becoming authenticated. PR #21 in v1.5.0 coordinated the existing rotation with account linking; it did not introduce rotation.

Rotation also discards pre-login session data, requires a free JaWS session slot, and leaves in-flight requests carrying the old cookie. Its protection is limited to prior cookie knowledge: an attacker who can keep reading cookies or responses can learn the replacement too.

Examine

Activity

  1. linkdata commented on Nov 6, 2026

    @linkdata
    OwnerAuthor

    Another case to examine with rotation: a top-level cross-site navigation to an OAuth login route can carry an existing JaWS SameSite=Lax cookie. If the provider approves without interaction, the callback rotates and closes that session. The apparent impact is forced sign-out, not account takeover. Please include a browser reproduction and decide whether the login entry needs a generic Fetch Metadata guard or whether this behavior is acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions