Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__Host-<CookieName>for sessions when JaWS recognizes HTTPS. These cookies carrySecure,Path=/, and noDomain.__Host-,__Secure-, and__Http-prefixed names as HTTPS-only, case-insensitively. Emit__Host-in canonical case for older browsers and document proxy scheme configuration and migration.Browsers that enforce the
__Host-prefix reject attempts by sibling domains or plaintext HTTP responses to set the HTTPS session cookie. Rotation is useful only if an attacker can make a victim use a known pre-login cookie, share the effective client IP JaWS sees, and cannot obtain the later cookie. linkdata/jawsauth#23 makes rotation opt-in.Compatibility
RotateSessionOnLoginsetting.CookieName; they do not share sessions with HTTPS.TrustForwardedHeadersand have the proxy replace client-supplied forwarding headers so JaWS sees the actual scheme and client IP.Verification
go generate ./...go vet ./...go build ./...go test -race ./...(full module)go test ./...staticcheck ./...,golangci-lint run,gosec ./...gofmt -l .andgofumpt -lon changed Go filesgit diff --checkon the AI guidance update