HTML annotate-mode toggle, icon copy actions, copy file contents - #23
Merged
Conversation
…ile contents HTML annotation (attn-wrf3): annotate mode is now off by default on every shell, a shared document included, so interactive artefacts keep their own links, buttons and tabs. A shell-owned note toggle pinned to the document viewport (⌘⇧N, Esc to leave) turns the hover outline / breadcrumb chip / click-to-comment surface on and off. The bridge re-states the mode after every handshake and the runtime refuses to emit a scope proposal once the mode is off. Recorded as decision #21 in amendments.md. Agent feedback polish (attn-926b): each margin card gets a Copy icon next to its time badge, and a bar pinned to the rail bottom copies all agent-assigned comments with file or project scope ("Copy selected" is dropped). Composers share an AssignToAgentCheckbox. A header "Copy file contents" action reads the raw file back through the attn:// handler, which now grants CORS only to the app document's own origin — never to the sandboxed HtmlViewer frame. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013sxC4SnV9vkNUV73fhdx8K
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #22 — work that was left uncommitted on
angus/agentic-enhancementswhen that PR merged. Needed before cutting v0.12.0.HTML annotation: off by default, pinned toggle (attn-wrf3)
HtmlAnnotateToggle.svelte,data-slot="html-annotate-toggle");⌘⇧N/Ctrl+Shift+Ntoggles,Escleaves when nothing sits above it. Mode persists across submit/cancel.falseincluded) after every handshake; the runtime'spickScoperefuses to propose once the mode is off and clears offered scopes oninspect: false.planning/collab/amendments.md;html-annotation.md§Goal and §5 amended.Agent feedback polish (attn-926b)
AgentFeedbackBar) copies all agent-assigned comments with file/project scope. "Copy selected" is dropped. Success shows as a check icon.AssignToAgentCheckbox.copy-file-contents.ts). To support it, theattn://file handler now returnsAccess-Control-Allow-Originfor non-markdown files only when the request origin is the app document (attn://app, or localhost in debug builds). The sandboxedHtmlViewerframe sendsOrigin: nulland still gets no CORS-clean read. Covered byapp_document_origin_grants_only_the_shell.Validation (local)
npm run check: 0 errors / 0 warningsnpm test: 150 test files, 0 failuresnpm run check:doc-runtime: artifact currentcargo fmt --check,cargo clippy --all-targets -D warnings: cleancargo test --bin attn app_document_origin: pass🤖 Generated with Claude Code
https://claude.ai/code/session_013sxC4SnV9vkNUV73fhdx8K