Repository navigation
fix: make Scaleform AddRef atomic - #50
Merged
Merged
Conversation
ozooma10
added a commit
to ozooma10/commonlibsf
that referenced
this pull request
Oct 21, 2026
Take upstream's finalized input/rebinding interfaces (PR libxse#49), atomic Scaleform AddRef (PR libxse#50) and BSStringT layout fix (PR libxse#52). Keep forge additions on top: ControlMap LoadCustomMappings and ApplyCustomMappings, SettingsDataModel SetGameplayOptionIndex and SaveSettings, and forge-only IDs (BSFaceDB, MenuCursor, BSWin32KeyboardDevice). Drop MappingRowStringDtor now that the row formatter uses BSString, and update the ControlMap test to expect heap text to be released through MemoryManager::Free.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RefCountImpl::AddRef()creates an atomic reference but incrementsrefCountdirectly.Use
myRefCountinstead, matching the atomic decrement inRelease().