Make remaining UI strings localizable - #816
Open
zamyatinmn wants to merge 2 commits into
Open
zamyatinmn wants to merge 2 commits into
zamyatinmn wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves remaining user-facing hardcoded strings to Android string resources so they can be translated by existing and future localizations.
This includes strings used by:
Also replaces the forced
Locale.USused for user-visible log dates with the device locale and adds plurals where required.No translations are added in this PR, and no layout or visual changes are intended.
Testing
aapt2git diff --checkpassesfossDebugresource processing and Kotlin compilation passed during development