Repository navigation
treewide: reword lime_release and extend the usage of libremesh.mk - #1274
Conversation
ca6817d to
f9f5a3d
Compare
d02a572 to
783a7bf
Compare
|
Edited the description to mention the removal of comments from the package lime-system using libremesh.mk |
|
|
||
| LIME_DESCRIPTION="$LIME_ID $DISTRIB_RELEASE $LIME_VERSION_CODE" | ||
|
|
||
| sed -i -e "s,^\(OPENWRT_RELEASE=\).*$/\1$LIME_DESCRIPTION/g" \ |
There was a problem hiding this comment.
here it seems that the expression uses a "," as a field separator, but then changes to "/", no?
There was a problem hiding this comment.
| $(1)/etc/lime_release \ | ||
| $(1)/etc/profile.d/10-lime-banner.sh | ||
| $(INSTALL_DIR) $(1)/etc/lime-assets/community/ | ||
| $(INSTALL_DIR) $(1)/etc/lime-assets/node/ |
There was a problem hiding this comment.
Aren't the new .placeholder files you introduced in this pull request enough for ensuring that these folders are created?
There was a problem hiding this comment.
The /etc/lime-assets/{community,node}/.placeholder is deleted as well as the whole /etc/lime-assets/.
It is created instead in the same way as the directory /etc/hotplug.d/lime-config/ during the package install phase, so by apk. It is indeed just to uniform the way lime-system creates the three empty directories.
There was a problem hiding this comment.
I don't understand, but it is ok :)
783a7bf to
e1c5e31
Compare
ilario
left a comment
There was a problem hiding this comment.
This is great!
Finally we are using the libremesh.mk file for every Makefile :D
Tested and it seems good to me and ready to merge, thanks!
Merge when you consider to.
6b6372d to
385a656
Compare
385a656 to
ec0f88f
Compare
ec0f88f to
75e6b2a
Compare
75e6b2a to
148c0d6
Compare
|
Introduced further changes, added also to the description, the news are: Tested on QEMU and now seems ready to go |
6fd9c42 to
8c96534
Compare
|
The lime-system post-install script was executing only during image creation. Retested on qemu |
hotplug-initd-services: create empty folder during package install The empty directory is created now during the package's install phase by the buildroot or the imagebuilder. Added it also to the package's conffiles to leave a trace of that for apk when it is ran from inside the device /etc/hotplug.d/initd/ libremesh.mk: extend the usage to all packages without a pkg_source_url lime-apply: do not run hooks if there aren't any i.e. if lime-app is not installed lime-debug: use libremesh.mk lime-docs: fix banner not displayed lime-system: use libremesh.mk to remove comments from the built package lime-system: drop compatibility script for v2020.4 migrate-wifi-bands lime-system: reword /etc/lime_release 'development' to 'nightly' which is shorter and emphasizes the fact that the code is usable but it is not a fixed/stable release. While 'development' is more vague. lime-system: reword lime_description and add it to /usr/lib/os-release from: LiMe master development (master rev. 0b6b5c5 20260810_1130) to: LibreMesh 25.12.5 r26.222.40775~0b6b5c5 nightly This text then displayed: - in the lime-app status page - via ssh after the banner via the profile.d/10-lime-banner.sh - via cli running `ubus call system board` lime-system: move the uci-defaults 89_lime-release execution to Makefile lime-system: create empty folders during package install The empty directories are created now during the package's install phase by the buildroot or the imagebuilder. Added them also to the package's conffiles to leave a trace of that for apk when it is ran from inside the device. /etc/hotplug.d/lime-apply/ /etc/hotplug.d/lime-config/ /etc/lime-assets/community/ /etc/lime-assets/node/ lime-system: prevent duplicated code for coloured prompt across sysupgrades scripts: add release.sh shared-state-async: symlink script and add the missing dependency on shared-state Fixes: libremesh#766
8c96534 to
fa734b4
Compare
|
Added a minor/trivial change to run hooks from lime-apply inside an 'sh -c' to Merging |
Fixes: #766