Skip to content

treewide: reword lime_release and extend the usage of libremesh.mk - #1274

Merged
a-gave merged 1 commit into
libremesh:masterfrom
a-gave:fix/libremesh_mk
Oct 9, 2026
Merged

a-gave merged 1 commit into
libremesh:masterfrom
a-gave:fix/libremesh_mk

Conversation

@a-gave

@a-gave a-gave commented Aug 27, 2026 •

Copy link
Copy Markdown
Contributor
hotplug-initd-services: create empty folder during package install
  The empty directory is created now during the package's install phase
  by the buildroot or the imagebuilder.
  Added it also to the package's conffiles to leave a trace of that
  for apk when it is ran from inside the device
  /etc/hotplug.d/initd/
libremesh.mk: extend the usage to all packages without a pkg_source_url
lime-apply: do not run hooks if there aren't any
  i.e. if lime-app is not installed
lime-debug: use libremesh.mk
lime-docs: fix banner not displayed
lime-system: use libremesh.mk to remove comments from the built package
lime-system: drop compatibility script for v2020.4 migrate-wifi-bands
lime-system: reword /etc/lime_release 'development' to 'nightly'
  which is shorter and emphasizes the fact that the code is usable but it
  is not a fixed/stable release. While 'development' is more vague.
lime-system: reword lime_description and add it to /usr/lib/os-release
  from: LiMe master development (master rev. 0b6b5c5 20260810_1130)
  to:   LibreMesh 25.12.5 r26.222.40775~0b6b5c5 nightly
  This text then displayed:
  - in the lime-app status page
  - via ssh after the banner via the profile.d/10-lime-banner.sh
  - via cli running `ubus call system board`
lime-system: move the uci-defaults 89_lime-release execution to Makefile
lime-system: create empty folders during package install
  The empty directories are created now during the package's install phase
  by the buildroot or the imagebuilder.
  Added them also to the package's conffiles to leave a trace of that
  for apk when it is ran from inside the device.
  /etc/hotplug.d/lime-apply/
  /etc/hotplug.d/lime-config/
  /etc/lime-assets/community/
  /etc/lime-assets/node/
lime-system: prevent duplicated code for coloured prompt across sysupgrades
scripts: add release.sh
shared-state-async: symlink script and add the missing dependency on
  shared-state

Fixes: #766

@a-gave
a-gave force-pushed the fix/libremesh_mk branch 5 times, most recently from ca6817d to f9f5a3d Compare August 27, 2026 11:07
@a-gave
a-gave marked this pull request as ready for review August 27, 2026 12:22
@a-gave
a-gave force-pushed the fix/libremesh_mk branch 2 times, most recently from d02a572 to 783a7bf Compare September 2, 2026 15:54
@a-gave

a-gave commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

Edited the description to mention the removal of comments from the package lime-system using libremesh.mk


LIME_DESCRIPTION="$LIME_ID $DISTRIB_RELEASE $LIME_VERSION_CODE"

sed -i -e "s,^\(OPENWRT_RELEASE=\).*$/\1$LIME_DESCRIPTION/g" \

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here it seems that the expression uses a "," as a field separator, but then changes to "/", no?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$(1)/etc/lime_release \
$(1)/etc/profile.d/10-lime-banner.sh
$(INSTALL_DIR) $(1)/etc/lime-assets/community/
$(INSTALL_DIR) $(1)/etc/lime-assets/node/

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't the new .placeholder files you introduced in this pull request enough for ensuring that these folders are created?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The /etc/lime-assets/{community,node}/.placeholder is deleted as well as the whole /etc/lime-assets/.
It is created instead in the same way as the directory /etc/hotplug.d/lime-config/ during the package install phase, so by apk. It is indeed just to uniform the way lime-system creates the three empty directories.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand, but it is ok :)

@ilario ilario left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!
Finally we are using the libremesh.mk file for every Makefile :D
Tested and it seems good to me and ready to merge, thanks!
Merge when you consider to.

@a-gave

a-gave commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor Author

Introduced further changes, added also to the description, the news are:

hotplug-initd-services: create empty folder during package install
  The empty directory is created now during the package's install phase
  by the buildroot or the imagebuilder.
  Added it also to the package's conffiles to leave a trace of that
  for apk when it is ran from inside the device
  /etc/hotplug.d/initd/
lime-system: move the uci-defaults 89_lime-release execution to Makefile
lime-system: create empty folders during package install
  The empty directories are created now during the package's install phase
  by the buildroot or the imagebuilder.
  Added them also to the package's conffiles to leave a trace of that
  for apk when it is ran from inside the device.
  /etc/hotplug.d/lime-apply/
  /etc/hotplug.d/lime-config/
  /etc/lime-assets/community/
  /etc/lime-assets/node/
lime-system: prevent duplicated code for coloured prompt across sysupgrades

Tested on QEMU and now seems ready to go

@a-gave
a-gave force-pushed the fix/libremesh_mk branch 2 times, most recently from 6fd9c42 to 8c96534 Compare October 7, 2026 14:55
@a-gave
a-gave deployed to physical-lab October 7, 2026 14:55 — with GitHub Actions Active
@a-gave

a-gave commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

The lime-system post-install script was executing only during image creation.
Removed in the last commit the check for IPKG_INSTROOT to let it run also when installing lime-system from apk from a plain openwrt

Retested on qemu

@a-gave
a-gave deployed to physical-lab October 7, 2026 15:50 — with GitHub Actions Active
@a-gave
a-gave deployed to physical-lab October 7, 2026 15:50 — with GitHub Actions Active
@a-gave
a-gave deployed to physical-lab October 7, 2026 15:50 — with GitHub Actions Active
@a-gave
a-gave deployed to physical-lab October 7, 2026 15:50 — with GitHub Actions Active
@a-gave
a-gave deployed to physical-lab October 7, 2026 15:50 — with GitHub Actions Active
@a-gave
a-gave deployed to physical-lab October 7, 2026 15:50 — with GitHub Actions Active
hotplug-initd-services: create empty folder during package install
  The empty directory is created now during the package's install phase
  by the buildroot or the imagebuilder.
  Added it also to the package's conffiles to leave a trace of that
  for apk when it is ran from inside the device
  /etc/hotplug.d/initd/
libremesh.mk: extend the usage to all packages without a pkg_source_url
lime-apply: do not run hooks if there aren't any
  i.e. if lime-app is not installed
lime-debug: use libremesh.mk
lime-docs: fix banner not displayed
lime-system: use libremesh.mk to remove comments from the built package
lime-system: drop compatibility script for v2020.4 migrate-wifi-bands
lime-system: reword /etc/lime_release 'development' to 'nightly'
  which is shorter and emphasizes the fact that the code is usable but it
  is not a fixed/stable release. While 'development' is more vague.
lime-system: reword lime_description and add it to /usr/lib/os-release
  from: LiMe master development (master rev. 0b6b5c5 20260810_1130)
  to:   LibreMesh 25.12.5 r26.222.40775~0b6b5c5 nightly
  This text then displayed:
  - in the lime-app status page
  - via ssh after the banner via the profile.d/10-lime-banner.sh
  - via cli running `ubus call system board`
lime-system: move the uci-defaults 89_lime-release execution to Makefile
lime-system: create empty folders during package install
  The empty directories are created now during the package's install phase
  by the buildroot or the imagebuilder.
  Added them also to the package's conffiles to leave a trace of that
  for apk when it is ran from inside the device.
  /etc/hotplug.d/lime-apply/
  /etc/hotplug.d/lime-config/
  /etc/lime-assets/community/
  /etc/lime-assets/node/
lime-system: prevent duplicated code for coloured prompt across sysupgrades
scripts: add release.sh
shared-state-async: symlink script and add the missing dependency on
  shared-state

Fixes: libremesh#766
@a-gave

a-gave commented Oct 9, 2026

Copy link
Copy Markdown
Contributor Author

Added a minor/trivial change to run hooks from lime-apply inside an 'sh -c'
from:

ACTION=$action "$file" >/dev/null

to

sh -c "ACTION=$action $file" >/dev/null

Merging

This branch is waiting to be deployed

1 waiting deployment
physical-lab — fa734b41 Waiting Oct 9, 2026 by a-gave via restore-lab-vlans #184
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate all LibreMesh-related packages' Makefile to libremesh.mk new format

2 participants