Repository navigation
HOA: read parity edges without acceptance set (#151) - #167
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #151.
Parity edges without an acceptance set are legal HOA (Spot's
randautwrites them). They now get a neutral priority with the parity the HOA formula gives on the empty set:high + 1for min kinds,1for max kinds (all other priorities shift up by two, keeping their parity). The range grows accordingly; overflow pastInt::MAXisHoaError::Acceptance(PriorityOverflow).Normalized once in
hoa_automaton_parts, sointo_dpa, the Python readers andparse_hoaneed no change. Fully colored inputs are unchanged. Such automata are written back colored with one (min) or two (max) extra sets, same language.test_parity_edges_without_color_are_readno longer xfail; two Python tests that expected an error for uncolored edges were adjusted