Repository navigation
Atoms for propositional alphabets: faster determinization (#157) - #162
Merged
Merged
Conversation
Owner
Author
Benchmarks
All 266 benchmarks
Instruction counts under valgrind on (), rustc 1.95.0 (59807616e 2026-04-14) (built from a source tarball), one execution per revision. A change counts if it is above 2 %. Wall-clock times are on the dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #157, following what Spot does.
Default path (faster)
Determinize::run/NFA::determinizeiterate over classes of symbols (atoms of the reachable edge labels) instead of all 2^aps valuations for propositional alphabets with more than 5 APs and at most 256*aps distinct labels (Spot's powerset rule). New defaulted hooksAlphabet::letter_classesandExpression::union.NFA::determinizemerges edges to the same state like Spot (Determinized::merge_edges,ts::operations::merge_parallel_edges).ts::determinize_propositional(added in Benchmark: determinization over a propositional alphabet #163): e.g. 10 APs / 8 states 37 s -> ~70 ms natively.Experimental (never used implicitly)
alphabet::Atoms(partition refinement with cached label covers,split_edges) and*_by_atomsmethods for Emptiness/Inclusion/Equivalence of DFA/DPA/DBA. They are slower than the regular methods in all benchmarks so far (benchmarks in benches/dpa.rs) and are documented as such.