Repository navigation
PropAlphabet: oxidd BDDs instead of biodivine-lib-bdd (#156, PR C) - #161
Merged
Merged
Conversation
Expressions over more than 6 atomic propositions are oxidd BCDDs in one global manager; labels use HOA syntax; hoars 0.5; MSRV 1.91.
Owner
Author
Benchmarks
All 259 benchmarks
Instruction counts under valgrind on (), rustc 1.95.0 (59807616e 2026-04-14) (built from a source tarball), one execution per revision. A change counts if it is above 2 %. Wall-clock times are on the dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #156 (PR C of three; A and the hoars 0.5 release are done).
What
PropExpressionover more than 6 APs is an oxidd complement-edge BDD in one global manager (variableiis APi). Truth tables stay for ≤ 6 APs. Equality, hashing and cloning are cheap, and independently built expressions can be combined. oxidd is private tosrc/alphabet/propositional/bdd.rs; a manager out of nodes (2^24) panics.0 & !1,t,f): newPropExpression::{try_new, new, proposition, unsatisfiable},PropAlphabetError::{InvalidExpression, UnknownProposition}. Output follows the BDD structure, never node ids.hoars0.5 (no BDD library); labels are unaliased and folded straight intoPropExpressions.HoaError::InvalidLabel(String)becomesUnknownProposition/UnresolvedAlias.from_parts,from_bdd,into_bdd,PropSymbol::{as,from}_bdd_valuation,PropAlphabet::expressions(a lock on everytry_make_expression, never read).python/andtools/bench.Tests
Differential proptest against brute force (1–10 APs, operators, matchers, symbols, parse/print round trip), parser errors, rendering independent of manager history, threads, HOA with aliases and 8 APs.
./scripts/checkpasses incl. Python.Not measured here
No before/after numbers (the benchmark service posts them once labelled
performance). Notes: rayon is still incargo treeviaoxidd-manager-index; a small program has ~25 MB RSS and ~1.4 GB virtual size from the node table. Nocargo build --timingscomparison and no frieda migration note yet.