Repository navigation
Parity games: PGSolver format, Python bindings, Oink differential tests - #153
Merged
Merged
Conversation
ParityGame::from_pgsolver/to_pgsolver read and write the PGSolver format. tests/oink.rs checks the solver against Oink on random games for all four parity conditions; nix/oink.nix packages Oink (the nixpkgs package of that name is unrelated) and the dev shell provides it. benches/game.rs benchmarks the solver.
MaxEven-, MinEven-, MaxOdd- and MinOddParityGame with add_vertex, add_edge, solve and the PGSolver format, and the exception GameError.
leonbohn
added a commit
that referenced
this pull request
Nov 9, 2026
Part of #143 (WP9), builds on #153. - `benches/versus/`: Python harness (`compare.py`, `@operation`/`Case`/`Contender`) with operations `dpa/equivalence`, `dpa/inclusion` (vs Spot, fixtures) and `game/solve` (vs Spot, Oink `zlk` and `ppp`; random and ladder games). Median wall-clock per side, inputs never timed, each comparison records whether both sides computed the same result. README explains how to add operations (e.g. determinization). - `tools/bench`: after the other targets the engine builds the wheel (`maturin`), runs the script and stores the rows (tables `versus`, `versus_settings`). New dashboard page `/versus` (latest `main`, ratio history per operation) and a section in the run view. Informational only; failing/missing tools skip it. Flags `--versus-script`, `--no-versus`. - Nix: `package.nix` wraps `maturin`, `python3`, Oink and Spot; module option `versusScript`; default `benches` now include `nondeterministic` and `game` (they were never run by the service, the list replaces the CLI default). - `python/tests/test_spot_games.py`: 100 random games against `spot.solve_parity_game`. CI: smoke run of the script in the Spot job. Checked locally: `cargo test/clippy` in `tools/bench`, `nix flake check --no-build`, an end-to-end `automata-bench run` (wheel build + script), pytest for the new test. Not run: `./scripts/check` (library untouched), the workflows, the real service.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #152.
ParityGame::from_pgsolver/to_pgsolver(PGSolver format),GameError::PgSolver.MaxEvenParityGame,MinEvenParityGame,MaxOddParityGame,MinOddParityGame(add_vertex,add_edge,solve,from_pgsolver,to_pgsolver) andGameError.tests/oink.rs, 200 random games per parity condition; skipped withoutoink). Theoinkpackage of nixpkgs is an unrelated DDNS client, sonix/oink.nixbuilds the solver; it is part of the dev shell.game(gungraun, added to the default benchmarks oftools/bench).nix develop(fails ifoinkis missing); the Nix jobs (nix flake check, Spot tests) useDeterminateSystems/magic-nix-cache-action. Other jobs are unchanged.Not run locally: the MSRV check (1.88) and the workflows themselves; the first CI run will show whether the cache action needs different permissions.