Repository navigation
Finish WP5 of #143: Python extras, Spot differential tests, bug fixes - #150
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes WP5 of #143 and adds differential tests against Spot (WP6); the bugs these tests found are fixed here.
Python bindings
to_dot()/_repr_svg_()for all classes (newDotStyleimpls in Rust for DCA, DRA, DSA, DMA, the other parity variants and the nondeterministic classes).DBA.complement()->DCA,DCA->DBA,DRA<->DSA(pairs swapped),DMA.complement().DBA.streamlined().python/README.md(classes, HOA support, install from GitHub:pip install "git+https://github.com/leonbohn/automata#subdirectory=python"),python/paragraph in CLAUDE.md. The PyPI release workflow is not used for now.Differential tests against Spot
python/tests/test_spot_*.py(markerspot, skipped without Spot): HOA round trips, emptiness + witness, inclusion/equivalence with counterexamples, complement, conversions, on the benchmark fixtures andspot.randautinputs;test_finite_words.py(no Spot) for DFA minimize / NFA determinize. ~25 s..github/workflows/python-spot.ymlruns them in the flake's dev shell (manual, weekly, and on PRs touchingsrc/automaton,src/ts/operations,src/hoa,python). Untested so far.Bugs found by the tests (fixed, one commit each)
PropAlphabetonly paired edges with equal expressions, losing transitions: wrongInclusion/Equivalence,DPA::prefix_partition, DFA union/intersection. Breaking for implementors ofExpression: new required methodintersection.State: 0 {0}).DPA::give_rejected_wordreturnedNonefor components reached via smaller priorities.DFA/Moore/Mealyminimizekept unreachable states; it now removes them (states numbered in BFS order, initial = 0). Benchmark results for minimization may change.Known
AcceptanceError(one remaining xfail).Checked with
./scripts/check(without the MSRV step) and 1326 pytest tests.