Repository navigation
Conversation
Malformed PDFs whose content stream never reaches a closing ']' previously drove (*buffer).readArray into an infinite loop: readToken returns io.EOF, the loop unreads it, calls readObject, which returns the same io.EOF, and the array slice grows by one element per iteration. On some inputs this allocates many GB before the process is OOM-killed. readDict already has the same io.EOF guard. This change adds the matching guard to readArray. Reproduced and validated with a content-stream-truncated PDF that previously hung at >30 GB resident memory; with the fix the parse returns cleanly within milliseconds.
Owner
|
@moberg The fix in this PR already exists in master. Commit 601f614 ("lex: stop readArray looping forever on io.EOF") adds the same check. The condition in readArray is now: This means the new block in this PR is not run. The io.EOF check in this PR can never be true at that point. So I will close this PR. But if you have any comment, feel free to add. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Malformed PDFs whose content stream never reaches a closing ']' previously drove (*buffer).readArray into an infinite loop: readToken returns io.EOF, the loop unreads it, calls readObject, which returns the same io.EOF, and the array slice grows by one element per iteration. On some inputs this allocates many GB before the process is OOM-killed.
readDict already has the same io.EOF guard. This change adds the matching guard to readArray.
Reproduced and validated with a content-stream-truncated PDF that previously hung at >30 GB resident memory; with the fix the parse returns cleanly within milliseconds.