Repository navigation
Fix cs_quat2euler degrees and duplicate CasADi function names - #152
Merged
Merged
Conversation
amacati
requested changes
Nov 3, 2026
- Convert radians to degrees in cs_quat2euler(degrees=True) instead of the inverse - Give the CasADi derivative conversion functions unique names
ratheron
force-pushed
the
fix-casadi-rotation
branch
from
November 18, 2026 16:46
2c8bba3 to
cc18ccd
Compare
amacati
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #151.
cs_quat2euler(degrees=True)converts the wrong wayThe degrees branch multiplied by
pi / 180instead of180 / pi(This is a silent error!). The test i added compares against scipy'sas_eulerfor extrinsic, intrinsic and symmetric sequences, in both radians and degrees.Duplicate CasADi function names in
rotation.pycs_ang_vel_deriv2rpy_rates_derivandcs_rpy_rates_deriv2ang_vel_derivwere both created with the name"cs_ang_vel2rpy_rates". I think this doesn't affect simulation results, but it gives misleading names in printouts and error messages.