refactor(Circuit): preserve intermediate synthesis targets - #935
Merged
SamuelSchlesinger merged 2 commits intoSep 23, 2026
Merged
SamuelSchlesinger merged 2 commits into
SamuelSchlesinger merged 2 commits into
Conversation
Keep both target families when composing synthesis bounds, and provide trans for retaining only the final targets. Add helpers for available unary and binary arguments, infer fold data from their proofs, and update shared-output examples and Lupanov synthesis.
SamuelSchlesinger
requested review from
arademaker,
chenson2018,
fmontesi,
kim-em and
sorrachai
as code owners
September 22, 2026 01:26
Replace the eight membership and pair gate helpers with Synthesis.of_mem and the existing operation combinators. Preserve intermediate targets in composition and inferred fold arguments while simplifying Boolean folds and shared-output examples.
barni120400
approved these changes
Sep 22, 2026
SamuelSchlesinger
enabled auto-merge
September 22, 2026 12:19
fmontesi
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep both target families when composing synthesis bounds, and provide trans for retaining only the final targets. Add of_mem to reuse available functions through existing synthesis combinators, infer fold arguments from their proofs, and simplify shared-output examples and Lupanov synthesis.
This is the first in a sequence of circuit-library refactors, preparing for a simpler circuit representation and a circuit-complexity API.