Repository navigation
Conversation
Generated-by: termag
There was a problem hiding this comment.
Risk: low.
Automated risk review (dry run): Low
This PR would be automatically approved.
Why: GuzzleFeatureRequester.php adds a one-line Guzzle decode_content gzip option, with new WireMock coverage in GuzzleFeatureRequesterGzipTest.php and a polling-gzip contract-test capability in TestService.php.
If you disagree with this review, share this PR in #feedback-agent-approvals or submit a changes-requested review explaining why.
Sent by Cursor Approval Agent: Dry-Run PR Approver
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Flag requests now send
Accept-Encoding: gzip, and the SDK decodes gzip-compressed responses. Uncompressed responses still work.GuzzleFeatureRequestersets Guzzle'sdecode_contenttogzip. Guzzle adds the request header and decodes the body with both the curl handler and the stream handler.Content-Encoding: identityto keep the bytes uncompressed.polling-gzipcapability.Opened from termag
Note
Overview
The polling HTTP client in
GuzzleFeatureRequesternow sets Guzzle’sdecode_contenttogzip, so flag/segment polls advertiseAccept-Encoding: gzipand transparently decode gzip response bodies while still handling uncompressed JSON.The contract test harness advertises a new
polling-gzipcapability. WireMock-backed integration tests verify the request header, gzip and plain responses, decoded bodies served from cache on replay, and correct behavior after a 304 revalidation withIf-None-Match.Reviewed by Cursor Bugbot for commit 2f84eaa. Bugbot is set up for automated code reviews on this repo. Configure here.