Skip to content

feat(kde): add portable plasma theme, widget, and panel installer - #123

Merged
lararosekelley merged 2 commits into
mainfrom
feat/kde-portable
Nov 20, 2026
Merged

lararosekelley merged 2 commits into
mainfrom
feat/kde-portable

Conversation

@lararosekelley

@lararosekelley lararosekelley commented Nov 20, 2026 •

Copy link
Copy Markdown
Owner

feat(kde): add portable plasma theme, widget, and panel installer


Stack managed by git-stk

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review-bot Code Review Bot: 1 finding(s) on da339c2.

Comment thread scripts/install-kde.py
return name
raise SystemExit("qdbus not found")


Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review-bot [Error Handling] shell_call surfaces a bare CalledProcessError traceback and hides qdbus stderr.

subprocess.run(..., check=True, capture_output=True) means that if plasmashell isn't running (SSH/TTY session, or before login) or the D-Bus call fails, apply --layout and capture die with a Python traceback. The captured stderr that says why is never shown. Catch CalledProcessError and raise SystemExit(f"{method} failed: {err.stderr.strip()}"), as qdbus() already does for a missing binary. This matters most for apply --layout, where the theme, widget and settings steps have already been applied by the time the panel step fails.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review-bot Fixed as of a5dd0b8.

@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

review-bot Code Review Bot - Confidence: 88/100 (+6 since the last review)

Adds a KDE Plasma installer (theme, pinned thermal widget, kwriteconfig settings, panel layout apply/capture) with data files, docs, just recipes and unit tests.

  • Prior findings: 1 fixed, 0 still open, 0 not verifiable.

No actionable findings.

The shell_call fix reads stdout as well as stderr, and tests cover both streams plus the check-before-change ordering for --layout.

Estimated cost so far $0.263 over 2 reviews: 312,363 tokens in (235,329 read from cache), 4,646 out.
  1. da339c2: $0.181: 159,513 tokens in (103,592 read from cache), 3,100 out.
  2. a5dd0b8: $0.081: 152,850 tokens in (131,737 read from cache), 1,546 out.

Automated code review provided by review-bot. Findings are advisory and should be vetted.

@lararosekelley

Copy link
Copy Markdown
Owner Author

@bot review

@github-actions

Copy link
Copy Markdown

review-bot Re-reviewed a5dd0b8: Confidence: 88/100 (+6 since the last review); 1 fixed, 0 still open, 0 not verifiable; no new findings. Summary

@lararosekelley
lararosekelley merged commit abcaa40 into main Nov 20, 2026
5 checks passed
@lararosekelley
lararosekelley deleted the feat/kde-portable branch November 20, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant