fix: restore interrupted audio and show upcoming set weight - #10
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switching apps or locking the screen could leave countdown cues silent even after explicit resume because the browser audio output reused an interrupted AudioContext. Retire that context on visibility loss/pagehide (including already-paused Sessions), activate fresh output in the next user gesture, and reschedule only the remaining cues. Ignore late activation success from the retired context and reuse decoded cue buffers.
The rest screen now shows the upcoming Prescribed Set's resistance alongside its target, including kg per implement, implement quantity, and bodyweight. It uses the same snapshot lookup and formatting as the active exercise.
Validation:
npm run checkpassed (374 passed, 1 optional test skipped).npm run release-checkpassed in an isolated checkout of the exact commit (including 228 UI tests, Chromium smoke, coverage and public-source privacy checks).Contract impact: clarify existing Session interruption behavior and rest-preview snapshot semantics; no API shape, database migration, or training-data changes. Real-device iOS lock-screen audibility is not established by the automated checks.