Repository navigation
Makefile: use update-codegen.sh bundled in the gengo-builder image, bump image to release-1.34 - #51
Merged
Merged
Conversation
…ump image to release-1.34 Replaces the old generate-groups.sh based clientset target with update-codegen.sh, a generic script bundled into CODE_GENERATOR_IMAGE (see appscodelabs/gengo-builder scripts/update-codegen.sh for the full env-var interface). GENERATORS is scoped to deepcopy only (no typed client), matching what the old generate-groups.sh call here actually generated -- there is no client/ directory in this repo. Also updates the openapi-% rule for the new openapi-gen CLI (positional packages + --output-dir/--output-pkg/--output-file instead of --input-dirs/--output-package). apis/ui/v1alpha1/openapi_generated.go was never checked into this repo (no git history for that path) and 'openapi' isn't wired into 'gen' here either (left as-is, matches existing composition), so this doesn't add it -- keeping the rule itself correct just means 'make openapi-ui_v1alpha1' still works if run by hand. The top-level 'openapi' target's later 'go run hack/gencrd/main.go' step fails because that file doesn't exist in this repo -- pre-existing, unrelated to this change, and also not wired into 'gen'/'verify' (verify here is verify-modules only). All 4 of this repo's +genclient types (Dbgate, Pgadmin, Phpmyadmin, MongoUi) already embed metav1.ObjectMeta, so no apis/ changes were needed even though no client is actually generated for them. Verified with make check-license, lint, build, unit-tests against the real gengo-builder release-1.34 image; deepcopy-gen's output is byte-identical to what was already checked in. Signed-off-by: Tamal Saha <tamal@appscode.com>
![kodiak-appscode[bot]](https://avatars.githubusercontent.com/in/92481?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the old
generate-groups.shbasedclientsettarget withupdate-codegen.sh, a generic script bundled intoCODE_GENERATOR_IMAGE(see gengo-builder's scripts/update-codegen.sh for the full env-var interface).GENERATORSis scoped todeepcopyonly (no typed client), matching what the oldgenerate-groups.shcall here actually generated -- there is noclient/directory in this repo.openapi-%is updated for the newopenapi-genCLI (positional packages +--output-dir/--output-pkg/--output-fileinstead of--input-dirs/--output-package).apis/ui/v1alpha1/openapi_generated.gowas never checked into this repo (no git history for that path) andopenapiisn't wired intogenhere either (left as-is), so this doesn't add it -- keeping the rule itself correct just meansmake openapi-ui_v1alpha1still works if run by hand.openapitarget's latergo run hack/gencrd/main.gostep fails because that file doesn't exist in this repo -- pre-existing, unrelated to this change, and not wired intogen/verifyeither (verifyhere isverify-modulesonly).All 4 of this repo's
+genclienttypes (Dbgate,Pgadmin,Phpmyadmin,MongoUi) already embedmetav1.ObjectMeta, so noapis/changes were needed even though no client is actually generated for them.Verification
Ran locally against the real
ghcr.io/appscode/gengo:release-1.34image:check-license,lint,build,unit-tests-- all pass.deepcopy-gen's output is byte-identical to what was already checked in.