Repository navigation
fix(reader): restore animated image playback on macOS - #1335
Merged
Merged
Conversation
start(sourceFileURL:targetView:) stored the target view and then called startPlayback, whose stop() cleared it again, so beginDisplay could not create the NSView display link and playback exited after the poster frame. Run the dedupe check and stop() before assigning the target view. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS, animated WebP and GIF pages in the DIVINA reader showed only their first frame and never animated, including after turning to a new page.
Cause
AnimatedImagePlayerController.start(sourceFileURL:targetView:)storedtargetViewand then calledstartPlayback, which callsstop()to tear down the previous playback.stop()clearstargetView, so when the first frame was readybeginDisplayhad no view to create theNSViewdisplay link from and playback exited. iOS and tvOS createCADisplayLinkwithout a view, so they were not affected.Fix
The "already playing this source" check and
stop()now run before the target view is assigned.startPlaybackonly sets up the new playback. iOS and tvOS use the same order.Validation
make formatmake build-macos,make build-ios,make build-tvossucceed🤖 Generated with Claude Code