Repository navigation
chore(deps): switch YueduCoreText to upstream 0.18.1 - #1332
Merged
Merged
Conversation
All kmworks fork changes have been merged upstream, so depend on the official CHANG-JUI-LIN/YueduCoreText releases instead of the fork branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Every change carried on the
kmworks/YueduCoreTextkmreaderbranch has been merged upstream (CHANG-JUI-LIN/YueduCoreText#3 through #18). Merging the fork branch into upstream0.18.1produces no diff, so the fork is no longer needed.What
https://github.com/CHANG-JUI-LIN/YueduCoreTextwithupToNextMinorVersionfrom0.18.1instead of the fork branch (minor bumps can break on 0.x).repo-conventionsskill.Impact
The fork was based on roughly 0.10.1. The 0.11 source-offset migration does not apply because KMReader restores CoreText positions by progression, not by
sourceTextoffsets. Layout refinements from 0.12–0.18 (WebKit UA stylesheet, ruby, text-emphasis, vertical images, single-page centering option) can shift page breaks and scroll heights slightly.Validation
make build-iossucceeds; the package resolved to0.18.1(5cc346a).🤖 Generated with Claude Code