Repository navigation
chore(web): adopt @kleinbem/web-config v0.2.0 - #65
Merged
Merged
Conversation
Pin the release tag, take the theme init block from 'web-config sync' and check it in the check script, drop settings that are now defaults. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
kleinbem
enabled auto-merge (squash)
November 17, 2026 11:01
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one): 1
Please check the settings in the CodeRabbit UI or the
|
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This was referenced Nov 17, 2026
kleinbem
added a commit
that referenced
this pull request
Nov 17, 2026
## Why osv-scanner now reports [RUSTSEC-2026-0543](https://osv.dev/RUSTSEC-2026-0543): every `chrono` release is marked unmaintained, with no fixed version. That fails fleet-lint on every PR in this repo (first seen on #65). Tracking: #66. An ignore entry would only postpone it, and the dependency is easy to drop: revue is the only crate in `Cargo.lock` that uses chrono, in three places, all for the current UTC time as a string. ## What - `chrono` → `jiff` (0.2, `std` feature only), one of the alternatives the advisory names. - New `db::now_rfc3339()` replaces the three `Utc::now().to_rfc3339()` calls. It keeps the `+00:00` offset chrono wrote, so new `created_at` values sort correctly next to existing rows (the column is text and indexed for `ORDER BY created_at DESC`). - `Cargo.lock`: chrono and the nine crates only it needed are gone; jiff and four helpers come in. No other version changes. One difference: jiff prints only as many fractional-second digits as needed, chrono padded to 3, 6 or 9. Nothing in the Rust code parses the value back. ## Tests - New unit test `now_rfc3339_matches_stored_format`. - `cargo test --all-targets`: 97 passed, 0 failed, 1 ignored (the live Ollama benchmark). - `cargo clippy --all-targets -- -D warnings` and `cargo fmt --check` clean. 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> <!-- coderabbit-ai-generated:v1 --> ## Summary by CodeRabbit * **Bug Fixes** * Review and feedback records now use consistent UTC timestamps, including the `+00:00` offset. * Newly created review records follow the same timestamp format, helping keep their dates consistent and correctly ordered alongside previously stored records. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
web-config is the fleet standard for the Svelte apps, but each app had its own dependency form, a hand copy of the theme init script and its own adapter settings. v0.2.0 (kleinbem/web-config#16, kleinbem/web-config#17) moves those into the package; this brings the app onto it, the same way in every app.
What
github:kleinbem/web-config#v0.2.0instead of a branch or commit.src/app.html: the hand-written theme / font-size script is replaced by the blocknpx web-config syncwrites. It only accepts known stored values.npm run checkrunsweb-config checkfirst, so a stale or hand-edited block fails CI.vite.config.ts: theadapterOptionsoverride is gone,build/+200.htmlis now the default.npmDepsHashupdated for the new lock.Tests
npm run check: 0 errors, 0 warnings.npm test: 6 of 6 pass.npm run build: writesbuild/withindex.htmland200.htmlas before.npmDepsHash) is verified by CI.🤖 Generated with Claude Code