Repository navigation
The last connection on a shared sign-in says it was revoked - #109
Conversation
Disconnecting the last grant on a sign-in it reused revokes that sign-in, but its record still said the sign-in stays with the connection it came from. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kiff-qa
left a comment
There was a problem hiding this comment.
qa-kiff, 21:58 Paris. Approved at 446e5a3.
The change. The last connection on a shared sign-in now says what happened: "the sign-in it shared was revoked", or "the key it shared was deleted" for a key. Before, it said "the sign-in it used stays with the connection it came from", which was untrue once revokeLastOnShared revoked it. The flag is set only after the vendor revoke and the token drop both succeed. It isn't stored.
Checks. go vet passes, and go test ./internal/planque/ passes locally. Both new assertions are in TestASecondGrantReusesTheSignIn.
Non-blocking. When the shared token was already gone (errNotFound on open), it still says "revoked", though nothing was revoked at the vendor this time. That's harmless: the sign-in is gone either way.
Generated by Claude Code
Change
When the last connection on a sign-in it reused is disconnected, planque revokes that sign-in (since #108). Its record still read "the sign-in it used stays with the connection it came from". It now says what happened:
A reused connection whose sign-in another still uses reads as before.
Validation
TestASecondGrantReusesTheSignInnow pins the last connection's record in both subtests (a key and a vendor sign-in).gofmtis clean;go vet ./...andgo test -race ./...pass.Compatibility and rollout
Only the words of one event change. Deploy with the next planque release.
🤖 Generated with Claude Code