Repository navigation
test(docscout): preserve multi-field requests within reply estimate - #81
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the compatibility regression for #77, which supersedes #63. A two-field extractor whose reply estimate fits the output allowance must make exactly one extraction call with the pre-batching request fingerprint, ordered fields, values, evidence and saved results. The existing single-field identity test remains unchanged.
The expected fingerprint is recorded against the extraction code before #77, then the same test passes against the current implementation on SQLite and PostgreSQL. A one-line source comment links the estimate weights to the completion-size samples reported in #63; the existing comments continue to describe them as heuristics.
Validation uses the official v0.3.59a runtime and freshly resolved dependencies: the affected successful-caller file passes all 10 tests on both engines against both implementations. Full Docscout suites pass 304 tests per engine, and lint passes. This changes tests and a comment only; extractor behavior, configuration, data and static assets remain unchanged.