-
Notifications
You must be signed in to change notification settings - Fork 0
feat(ai-atlas): the push sets the map, the cards and every page word #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0bd4d30
ai-atlas: Grok joins the Engine and Models cards, Delivered work name…
manager 1a7ef29
ai-atlas: Wolf's card texts can arrive with the pushed guide
manager 17e9dd2
ai-atlas: the Terminal's push sets the map and every page word
manager 2efc36c
ai-atlas: pushed map labels stay short, empty text is refused
manager ca5066d
ai-atlas: the brand title is a short label too
manager File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good fix for the map-node overflow risk, but
brandTitleis missing from this list. It renders in the same.doc-header .header-leftrow asmetaLabel(src/pages/ai-atlas.tsx:1546-1559), and that row iswhite-space: nowrapwith no overflow handling (src/styles/ai-atlas.css:116-133).brandTitleis also run through.split(' ').map(w => w.toUpperCase().split('').join(' ')).join(' · ')before rendering (ai-atlas.tsx:1549-1552), which inserts a space between every letter — so a pushed value near the 4000-char general cap would blow out to several times its length and overflow the header, the same failure modemetaLabel/apexLabel/etc. were just capped to prevent.Since
brandTitlesits in the identical nowrap row asmetaLabel, it should get the sameSHORT_LABEL_MAXtreatment.[Fix this →](https://claude.ai/code?q=In%20src%2Flib%2FaiAtlas%2Fadapter.ts%2C%20add%20%27brandTitle%27%20to%20the%20SHORT_LABEL_KEYS%20Set%20(around%20line%2045-59).%20It%20renders%20in%20the%20same%20.doc-header%20.header-left%20row%20as%20metaLabel%20(src%2Fpages%2Fai-atlas.tsx%20around%20line%201546-1559)%2C%20which%20is%20white-space%3A%20nowrap%20with%20no%20overflow%20handling%20(src%2Fstyles%2Fai-atlas.css%20line%20116-133)%2C%20and%20brandTitle%20is%20additionally%20expanded%20by%20a%20per-letter-spacing%20transform%20before%20render%2C%20amplifying%20any%20overflow.%20It%20should%20get%20the%20same%20SHORT_LABEL_MAX%20cap%20as%20metaLabel%20since%20a%20long%20pushed%20value%20would%20overflow%20the%20header%20the%20same%20way%20the%20map%20node%20labels%20did%20before%20this%20fix.&repo=keepsimpleio/KeepSimpleOSS