Skip to content

fix(pages): publish every page, not a remembered list - #16

Merged
arudaev merged 1 commit into
mainfrom
fix/publish-every-page
Nov 6, 2026
Merged

arudaev merged 1 commit into
mainfrom
fix/publish-every-page

Conversation

@arudaev

@arudaev arudaev commented Nov 6, 2026

Copy link
Copy Markdown
Member

Closes #15

/impressum.html has been answering 404 on the live site. The page is in the repository and every footer links to it; the workflow simply never copied it, because it copies a hand-written list:

cp index.html 404.html styles.css kiosk.js robots.txt .nojekyll _site/

It is the one page a German site is legally required to carry, so this is worth its own change rather than riding along with the domain move.

What changes

  • The copy is a glob, so a page added tomorrow is published tomorrow.
  • A check fails the build if index.html, impressum.html, 404.html, styles.css or kiosk.js is missing from _site — the failure mode here was silence, and silence is what made it last.
  • CNAME is copied when present. This site publishes through a workflow (build_type: workflow), not from a branch, so a CNAME file in the repository root is not picked up automatically: it has to be in the artifact. Without this line chore(domain): the apex, ready to switch on #14 would merge and change nothing, which is worth knowing before the cutover rather than during it.

Found while preparing #14.

The workflow copied a hand-written list of files into _site. impressum.html
was added after that list was written and never joined it, so the Impressum
link in the footer has been answering 404 on the live site — the one page a
German site is legally required to have.

The copy is a glob now, a check fails the build if a page that must exist is
missing, and CNAME is copied when it is there, which is what a custom domain
needs on a workflow-published site.

Closes #15
@github-actions github-actions Bot added the area:delivery CI, workflows, deployment and repository settings label Nov 6, 2026
@github-actions github-actions Bot added the type:bug Something behaves differently from how it should label Nov 6, 2026
@arudaev
arudaev merged commit 3e579c7 into main Nov 6, 2026
4 checks passed
@arudaev
arudaev deleted the fix/publish-every-page branch November 6, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:delivery CI, workflows, deployment and repository settings type:bug Something behaves differently from how it should

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The Impressum is not published: /impressum.html is a 404

1 participant