Repository navigation
fix(pages): publish every page, not a remembered list - #16
Merged
Merged
Conversation
The workflow copied a hand-written list of files into _site. impressum.html was added after that list was written and never joined it, so the Impressum link in the footer has been answering 404 on the live site — the one page a German site is legally required to have. The copy is a glob now, a check fails the build if a page that must exist is missing, and CNAME is copied when it is there, which is what a custom domain needs on a workflow-published site. Closes #15
4 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15
/impressum.htmlhas been answering 404 on the live site. The page is in the repository and every footer links to it; the workflow simply never copied it, because it copies a hand-written list:It is the one page a German site is legally required to carry, so this is worth its own change rather than riding along with the domain move.
What changes
index.html,impressum.html,404.html,styles.cssorkiosk.jsis missing from_site— the failure mode here was silence, and silence is what made it last.CNAMEis copied when present. This site publishes through a workflow (build_type: workflow), not from a branch, so aCNAMEfile in the repository root is not picked up automatically: it has to be in the artifact. Without this line chore(domain): the apex, ready to switch on #14 would merge and change nothing, which is worth knowing before the cutover rather than during it.Found while preparing #14.