Skip to content

Release: build and embed the ssh write head - #21

Merged
mangelajo merged 1 commit into
mainfrom
fix/release-embed-write-head
Oct 14, 2026
Merged

mangelajo merged 1 commit into
mainfrom
fix/release-embed-write-head

Conversation

@mangelajo

Copy link
Copy Markdown
Member

Problem

The release pipeline never built remote/flswh-aarch64-qnx7, so build.rs
silently embedded an empty placeholder and release binaries failed at runtime
with No embedded write head: build it with make remote-wh or pass --wh-bin.
The write head was only built on PRs (via the write-head job in ci.yml).

Fix

  • Add the write-head job to release.yml (podman QNX cross build,
    ELF/SONAME/NEEDED artifact verification, artifact upload with
    if-no-files-found: error)
  • build-and-release now has needs: write-head and downloads the artifact
    into remote/ before cargo build

If the write head fails to build or verify, the release build now fails
instead of shipping an empty embed.

Verification

  • YAML validated
  • Job is a copy of the proven write-head job from ci.yml

The release pipeline never built remote/flswh-aarch64-qnx7, so build.rs
silently embedded an empty placeholder and release binaries failed at
runtime with "No embedded write head". Add the write-head job from
ci.yml (podman QNX cross build, artifact verification) and make
build-and-release depend on it and download the artifact before
cargo build.

Assisted-by: OpenCode
Co-Authored-By: Qwen 3.8 27B <noreply@qwen.ai>
@coderabbitai

coderabbitai Bot commented Oct 14, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b2a6e2ed-302f-4a8d-9e70-7f9fd1878fc7
📥 Commits

Reviewing files that changed from the base of the PR and between 88115d8 and fff50c7.

📒 Files selected for processing: 1
  • .github/workflows/release.yml
 _____________________________________________________________________________________________________________________________
< If debugging is the process of removing bugs, then programming must be the process of putting them in. - Edsger W. Dijkstra >
 -----------------------------------------------------------------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mangelajo
mangelajo merged commit 25adbfd into main Oct 14, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant