Repository navigation
Release: build and embed the ssh write head - #21
Merged
Merged
Conversation
The release pipeline never built remote/flswh-aarch64-qnx7, so build.rs silently embedded an empty placeholder and release binaries failed at runtime with "No embedded write head". Add the write-head job from ci.yml (podman QNX cross build, artifact verification) and make build-and-release depend on it and download the artifact before cargo build. Assisted-by: OpenCode Co-Authored-By: Qwen 3.8 27B <noreply@qwen.ai>
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 1
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The release pipeline never built
remote/flswh-aarch64-qnx7, sobuild.rssilently embedded an empty placeholder and release binaries failed at runtime
with
No embedded write head: build it with make remote-wh or pass --wh-bin.The write head was only built on PRs (via the
write-headjob inci.yml).Fix
write-headjob torelease.yml(podman QNX cross build,ELF/SONAME/NEEDED artifact verification, artifact upload with
if-no-files-found: error)build-and-releasenow hasneeds: write-headand downloads the artifactinto
remote/beforecargo buildIf the write head fails to build or verify, the release build now fails
instead of shipping an empty embed.
Verification
write-headjob fromci.yml