Repository navigation
Preserve Text subclass behavior when compiling models - #191
Open
narayana006 wants to merge 1 commit into
Open
narayana006 wants to merge 1 commit into
narayana006 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-in-place
Text.compile()reconstructs a plainTextobject, losing a custom model's class, formatting hooks and constructor configuration. For example, aword_joinhook that removes POS tags emits clean words before compilation but raw tagged tokens afterward.Shallow-copy the model and replace its chain with the independently compiled chain. This preserves subclass behavior and configuration without invoking a constructor that may require additional arguments. Mutable custom attributes retain shallow-copy semantics.
Seven regression/control tests cover subclass identity and sentence splitting, custom word output, required constructor configuration,
retain_original=False, recompilation, original-chain independence and in-place compilation. Five fail before the fix; two controls pass. With the fix, all 92 tests pass, pytest-cov reports 100% statement coverage, and projectmake lint(Black and Flake8) passes on macOS/Python 3.11.15.The full Python/platform CI matrix and NLTK/spaCy integrations were not run; the tagging regression uses a small deterministic subclass.
AI assistance: OpenAI Codex assisted with investigation, implementation, regression tests and local validation. Publication was explicitly approved by the contributor.