Skip to content

Add missing functions - #630

Merged
kchanqvq merged 2 commits into
jscl-project:masterfrom
VisenDev:compat
Nov 7, 2026
Merged

kchanqvq merged 2 commits into
jscl-project:masterfrom
VisenDev:compat

Conversation

@VisenDev

@VisenDev VisenDev commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Was writing some code using jscl and I noticed these standard functions were unimplemented

@kchanqvq kchanqvq left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good, I made some small comments.

Comment thread src/numbers.lisp Resolved
Comment thread src/numbers.lisp
(defun cos (radians)
(if (numberp radians)
(#j:Math:cos radians)
(error 'type-error :datum radians :expected-type 'number)))

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is check-type available at this stage?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check-type doesn't show up anywhere else in this file, i'm not familiar enough with the codebase to know beyond that

@kchanqvq
kchanqvq merged commit 5ee3ab6 into jscl-project:master Nov 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants