Drop the leftover updater tarball and clarify release asset names - #27
Merged
Merged
Conversation
Removing "app" from bundle.targets stops Tauri from also exposing the raw .app bundle as a release artifact — tauri-action was tarring it up as KeyAura_aarch64.app.tar.gz on every release even though this app has no updater plugin configured to ever consume it. Verified locally: dmg packaging still builds the .app internally as an implicit intermediate step, so the actual installer is unaffected. Also renames each platform's installer from the bundler's default naming (KeyAura_0.1.4_aarch64.dmg, KeyAura_0.1.4_x64-setup.exe) to something self-explanatory (KeyAura_0.1.4_macOS-AppleSilicon.dmg, KeyAura_0.1.4_Windows-x64.exe), via a per-matrix-leg platform_label field that a future Linux leg can extend without inventing a new convention. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Merged
jonathanlaf
added a commit
that referenced
this pull request
Sep 15, 2026
## Summary Version bump only — the features shipping in this release (#27, #28) were merged straight to `main` rather than through this release branch, so the automated release-notes script won't pick them up. Noting them here manually: - #27 — drop the leftover updater tarball from releases, clearer per-platform asset naming - #28 — macOS auto-update: checks for updates on launch and via a tray "Check for Updates…" item, with a confirm-before-download/confirm-before-restart flow; signing key generated and wired into CI ## Verification - `cargo fmt --check`, `cargo clippy --locked --all-targets -- -D warnings` (dev and release), `cargo test --locked` — clean, 33 passing - `node --test ui/test/*.test.mjs` — 38 passing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"app"fromtauri.conf.json'sbundle.targets— this was the cause ofKeyAura_aarch64.app.tar.gzshowing up on every release even though there's no updater plugin configured to ever fetch it. Verified locally with a realcargo tauri build: the.dmgstill builds correctly (the.appis still built as an internal intermediate step for dmg packaging, it's just no longer separately exposed/tarred as a release artifact)KeyAura_0.1.4_aarch64.dmg→KeyAura_0.1.4_macOS-AppleSilicon.dmg,KeyAura_0.1.4_x64-setup.exe→KeyAura_0.1.4_Windows-x64.exe, via a newplatform_labelmatrix field a future Linux leg can extend with the same "OS-arch" naming rather than inventing something newVerification
cargo fmt --check,cargo clippy --all-targets -- -D warnings(dev and release),cargo test— clean, 33 passingcargo tauri buildconfirming the dmg still builds correctly and no.app.tar.gz/stray files remain in the bundle output/code-review(medium); found and fixed one real bug before this PR: the rename step originally usedcpinstead ofmv, which would've left the bundler's original-named file behind — the next step's provenance-attestation glob (*.dmg/*.exe) would then match both files and attest over a name no longer even published