Skip to content

build rpms with the install script and on release - #315

Open
tomspur wants to merge 6 commits into
johannesjo:mainfrom
tomspur:feature/rpm
Open

tomspur wants to merge 6 commits into
johannesjo:mainfrom
tomspur:feature/rpm

Conversation

@tomspur

@tomspur tomspur commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Description

This merge request builds a rpm with the install script, so that I can easily install it on Fedora. Furtermore it also adds it to release workflow

Issues Resolved

  • Building an RPM locally with install.sh and also on release

Check List

  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.

@johannesjo

Copy link
Copy Markdown
Owner

Thanks — rpm support is welcome. One blocker: the Linux branch of install.sh no longer goes through npm run build, so it loses the umask 022 added in #281. Under a restrictive umask the .desktop file, package root and a few resources end up without world-read, for both deb and rpm. Could you add umask 022 before the build commands in the Linux branch?

Smaller things:

  • Check for rpmbuild (rpm-build) before taking the rpm path, with a hint if it's missing — on a plain Fedora box fpm fails with an unclear error.
  • --no-install is Linux-only and undocumented; please mention it (or make it a no-op with a message on macOS).
  • Could you confirm from a Fedora install that the rpm shows up in the app menu and opens parallelcode:// links?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants