Repository navigation
feat: course sites show their own mark, and no card icon sits in a box - #7
Merged
Merged
Conversation
…dy shows what is being made
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Punch list 78–87, stacked in one PR.
lms_site_icon: apple-touch-icon or favicon at the origin, fetched once a week, misses remembered), else the Canvas or Moodle mark (Simple Icons, CC0, with notices), else a D2L / Bb monogram. In Courses, the course sites list, the connect dialog and the import dialog.features/study/jobs.ts), not in the dialog: closing the dialog keeps the run going ("Close, keep making it"); Study lists runs under Making now with progress and Stop and reloads when one ends; a run nobody watches announces itself with a toast and an Open action; pressing Make again for the same course, test and kind joins the run instead of starting another. A quiz the assistant proposes in chat makes itself on one click when its plan says enough, with progress under the card; the dialog opens only when an answer is missing (what an unmapped test covers). Previously closing the dialog silently stopped the run while the copy said it kept going.vitest.config.tsresolves the web@alias so web stores can be unit tested;e2e/model.spec.tspolls for the request's effort (a race on slow runners).Checks:
pnpm typecheck,pnpm lint,pnpm test(907 passed; new job store and site icon tests),pnpm test:ui(33 passed;desktop.specruns in CI); screenshots of every changed screen and the chat→Study→toast flow in the mock.