Skip to content

feat: course sites show their own mark, and no card icon sits in a box - #7

Merged
jerynv merged 6 commits into
mainfrom
ui/bare-marks
Nov 15, 2026
Merged

jerynv merged 6 commits into
mainfrom
ui/bare-marks

Conversation

@jerynv

@jerynv jerynv commented Nov 15, 2026 •

Copy link
Copy Markdown
Owner

Punch list 78–87, stacked in one PR.

  • No boxes. Settings cards lead with the bare glyph or brand mark; the plan rows, course sites list, connect dialog and viewer placeholder lose their bordered squares. The P mark is Phaethon blue everywhere. About › License is "MIT" and a link to the licence on GitHub.
  • Course sites show their own mark. The school's icon when the site serves one (lms_site_icon: apple-touch-icon or favicon at the origin, fetched once a week, misses remembered), else the Canvas or Moodle mark (Simple Icons, CC0, with notices), else a D2L / Bb monogram. In Courses, the course sites list, the connect dialog and the import dialog.
  • File references read like links: glyph, link colour, underline on hover; no tint box, no path tooltip. Citations the same, muted.
  • Making a quiz or deck now lives in a job store (features/study/jobs.ts), not in the dialog: closing the dialog keeps the run going ("Close, keep making it"); Study lists runs under Making now with progress and Stop and reloads when one ends; a run nobody watches announces itself with a toast and an Open action; pressing Make again for the same course, test and kind joins the run instead of starting another. A quiz the assistant proposes in chat makes itself on one click when its plan says enough, with progress under the card; the dialog opens only when an answer is missing (what an unmapped test covers). Previously closing the dialog silently stopped the run while the copy said it kept going.
  • vitest.config.ts resolves the web @ alias so web stores can be unit tested; e2e/model.spec.ts polls for the request's effort (a race on slow runners).

Checks: pnpm typecheck, pnpm lint, pnpm test (907 passed; new job store and site icon tests), pnpm test:ui (33 passed; desktop.spec runs in CI); screenshots of every changed screen and the chat→Study→toast flow in the mock.

@jerynv
jerynv merged commit cd50c03 into main Nov 15, 2026
6 checks passed
@jerynv
jerynv deleted the ui/bare-marks branch November 15, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant