story-152: Every finding routed to the story is fixed, filed or reported, and the run says which - #308
Merged
Conversation
…reported, and the run says which
…ted, and the run says which Implemented by the l5 harness story workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
story-147 stopped the inspection filing a brief about a story's own change and routed the finding to that story's verifier instead. Where the verifier acted, that was the whole point. Where it passed over one — which its prompt explicitly permits, and rightly — the finding had nowhere left to go: written to a run-directory artifact, read by nothing after the verdict, and never filed. The mechanism had traded a growing backlog for a silent drop.
story-151 is the completed instance, and it lost two rather than one. Its inspection routed a finding on each attempt —
git-pointer-satisfies-the-history-assertion, thencopied-repository-shares-its-git-directory, the second a real defect about the very change that story made. Both verdicts recordedpassed, zero blocking issues, zero correctable findings. The run completed with0 filed. Recovering them took reading two JSON files by hand.Every routed finding is accounted for
The verifier names a finding's
slugin thelocationof any blocking issue or correctable finding it raises from one. After the verdict, every routed finding whose slug no entry names is filed as a brief.The bias is toward over-filing rather than loss, and the prompt says so where the verifier reads it: declining a finding is still right and now sends it to the backlog instead of deleting it, and a finding acted on without its slug named is filed too — as a duplicate a person closes, which is the cheaper mistake of the two.
Both verifier prompts carry it, so the refactor workflow is not left behind.
The summary stopped claiming an outcome it could not know
answered by the story: Nbecamerouted to this story: N. The line is composed when the inspection finishes, before the verifier has read anything, so routing was the only thing true at that moment — the old wording described a destination in the tense of a thing already done. What became of them is written afterwards, as its own record carryingroutedandacted_on.A re-entry says how much of it is the Inspector's
A correction pass or retry raised from routed findings now says how many of the findings it carries are among them. Before, a pass spent on the Inspector's reading and one spent on the verifier's own read identically, and telling them apart meant opening the artifact and the verdict and comparing.
A note on this run
Its own events read
routed to this story: 2with0 filedon both attempts, and its final verdict records zero blocking and zero correctable. Those four findings went the old way, because the harness executing a run is the one the developer invoked rather than the one on the branch. This is the last run that can happen to.Planned from the brief filed under 302.
🤖 Generated with Claude Code
https://claude.ai/code/session_01NJzpgnY9aJ7K2godyjrJJR