feat(cli): add the combined later-decision-and-relation-type prompt (#1014) - #1068
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR 13 of the
decision-revision-detectorchain, which is Phase B slice P8a (stacked-to-main)._ask_later_decision_and_type(a, b)insrc/openkos/cli/main.pyis the combined confirmation prompt that P8b'sreconcile --from-findingsrevision walk will use. In one question the human picks which Decision is later and which relation it records,supersedes(a reversal) orrevises(a refinement), across four numbered choices. They can also skip, and an unrecognized answer re-asks. The direction comes from the human here, never from the model (ADR-0025).It has no caller yet; P8b wires it in.
Related issue
Refs #1014
Type of change
feat— new featureHow was this tested?
AttributeError) on all 5 new tests. They cover the 4-way mapping, parametrized, plus skip, empty and re-ask.1, and replacing the re-ask loop with a silent skip.ruff check .,ruff format --check .andmypy .are clean;pytest --cov6891 passed (96.98%);evals/run_self_tests.py43 of 43.Checklist
ruff,mypy,pytest).