Skip to content

feat(cli): add the combined later-decision-and-relation-type prompt (#1014) - #1068

Merged
jasonssdev merged 2 commits into
mainfrom
feat/1014-phase-b-p8a-prompt
Sep 29, 2026
Merged

jasonssdev merged 2 commits into
mainfrom
feat/1014-phase-b-p8a-prompt

Conversation

@jasonssdev

Copy link
Copy Markdown
Owner

Summary

PR 13 of the decision-revision-detector chain, which is Phase B slice P8a (stacked-to-main).

_ask_later_decision_and_type(a, b) in src/openkos/cli/main.py is the combined confirmation prompt that P8b's reconcile --from-findings revision walk will use. In one question the human picks which Decision is later and which relation it records, supersedes (a reversal) or revises (a refinement), across four numbered choices. They can also skip, and an unrecognized answer re-asks. The direction comes from the human here, never from the model (ADR-0025).

It has no caller yet; P8b wires it in.

Related issue

Refs #1014

Type of change

  • feat — new feature

How was this tested?

  • Strict TDD: RED was observed (AttributeError) on all 5 new tests. They cover the 4-way mapping, parametrized, plus skip, empty and re-ask.
  • 2 mutations, each killed: swapping holder and target on choice 1, and replacing the re-ask loop with a silent skip.
  • The 74 existing reconcile tests stay green, so the existing prompts are unchanged.
  • ruff check ., ruff format --check . and mypy . are clean; pytest --cov 6891 passed (96.98%); evals/run_self_tests.py 43 of 43.

Checklist

  • My commits follow Conventional Commits.
  • I added or updated tests for the change.
  • I updated docs where behavior, interfaces, or the knowledge model changed.
  • Lint, format, type check, and tests pass locally (ruff, mypy, pytest).
  • Output remains OKF-conformant and derived stores stay reconstructible from the bundle + sources.
  • The change is consistent with the project's guiding principles (local-first, provenance, freshness, human-in-the-loop).

@jasonssdev
jasonssdev merged commit 8d5169e into main Sep 29, 2026
9 checks passed
@jasonssdev
jasonssdev deleted the feat/1014-phase-b-p8a-prompt branch September 29, 2026 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant