Repository navigation
Fix macos-latest build - #38
Merged
Merged
Conversation
Contributor
Author
Managed to borrow my buddy's set today for testing today. LibreCAL-GUI starts properly on MacOS 27.0.1 and connects to the instrument. There will be a similar PR in the LibreVNA repo that largely mirrors this one. |
Owner
|
Thank you so much for taking a look at this. I can not test this on my side due to lack of macos hardware (otherwise I would have fixed this myself a long time ago). I'll take your word for it and merge it as is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
I noticed some QT modules were not being linked in macos-latest stable which was causing a crash on start on MacOS 26 and 27. I believe the root of the problem was
echo "/usr/local/opt/qt@6/bin" >> $GITHUB_PATHpoints to the intel homebrew path instead of the arm path.Solutions
I think this same fix can be applied to the LibreVNA gui, I'll probably work on that after we merge this here.
This may close #34
I do not have a librevna/librecal of my own so I'm working on borrowing a set for testing, if you could test this on your end as well it would help a lot.