Repository navigation
Use DLAPY2 instead of hypot to match Fortran - #20
Conversation
hypot differs from DLAPY2 in last bits; flips AB13CD/AB13DD branch tests (e.g. AB13CD returned hnorm/2). Sites: ab13dd, ab13cd, ma01ad, mb03rd, mb04ad. Add Fortran differential tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0637882b46
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
hypot()withSLC_DLAPY2at every site where SLICOT Fortran usesDLAPY2:ab13dd.c(6 sites ↔ 8 Fortran calls),ab13cd.c,ma01ad.c,mb03rd.c(5),mb04ad.c.hypotdiffers from DLAPY2 in last bits (~22% of inputs vs Accelerate), enough to flip threshold tests; AB13CD could stall and return hnorm/2.test_ab13cd_fortran_reference.py(half-norm stall, lightly damped mode), one AB13DD near-imaginary-axis case. All fail on pre-change build.Validation
test_ab13fdhtml,test_mb04tbblocked path,test_sb10ddhtml) also fail on pre-change build.check_translation_smells.pyclean.🤖 Generated with Claude Code