Repository navigation
Fix SG02AD scaling for factored Q/R - #19
Merged
Merged
Conversation
SCAL='G' scaled factors C/D by SCALE, so C'C/D'D got SCALE^2 -> wrong X. Scale factors by sqrt(SCALE), as SB02OD does. SLICOT-Reference#46. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SG02ADwithJOBB='B',SCAL='G',FACTinC|D|Bscaled factors C/D bySCALE, soC'C/D'Dwere scaled bySCALE^2while X was unscaled bySCALE-> wrong solution.sqrt(SCALE)(same asSB02OD).Scalar case A=B=E=Q=R=1, DICO='C': expected X = 1+√2. Before: FACT C/D/B -> 2.2247 / 1.3660 / 1.2071. After: 2.4142.
Tests
test_scaling_factored_scalar: issue case, FACT C/D/B.test_scaling_factored_matches_unfactored: DICO C/D × FACT C/D/B × JOBL Z/N vs FACT='N' unscaled.test_mb04tbblocked path /test_sb10ddFortran-reference mismatches (fail on main too).🤖 Generated with Claude Code