feat: log requests, errors and exits - #17
Merged
Merged
Conversation
This was referenced Sep 22, 2026
Closed
turegjorup
force-pushed
the
feature/8293-logging
branch
from
September 23, 2026 07:16
daa6c13 to
d674bf4
Compare
rimi-itk
approved these changes
Sep 24, 2026
turegjorup
added this pull request to stack #32
September 24, 2026 11:12
turegjorup
force-pushed
the
feature/8293-logging
branch
from
September 24, 2026 11:27
d674bf4 to
5f9da63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds logging to
app.js, and runs Express in production mode on the server.https://leantime.itkdev.dk/#/tickets/showTicket/8293
Changes
req GET ... aborted after 30012ms).finishnever fires for those, and they disappear entirely once nginx is gone (refactor: route traefik straight to node and drop nginx #23).uncaughtException,unhandledRejection,SIGTERMandSIGINT.docker-compose.server.yml:NODE_ENV=production. It was unset, so Express ran in development mode: its default error handler logged the stack a second time and put the stack trace, server names included, in the 500 response body.Console only. No new dependency.
Verify
Expected:
7/7 passed, and lines of the formreq GET /posidryeartsl.csv 200 142ms rows=500 ip=...in the node log.Stacked on #16.