Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KeyTransformDatastore.query()andqueryKeys()applyconvert()to already-transformed keys before calling user filters. A filter on the original key can then reject matching entries. Useinvert()instead, consistent with the prefix and ordering paths.Adds four regressions for original-key filters, ordering/pagination, and
ShardingDatastore. All four fail on58d2e06and pass with this change. A separate check withShardingDatastoreoverFsDatastorealso went from empty results to the expected keys.Checked locally on Linux arm64 with Node 24.21.0:
npm run build,npm run lint,npm run dep-checknpm run test:node: 835 passing across the monoreponpm run test:chrome --workspace datastore-core,npm run test:chrome-webworker --workspace datastore-core,npm run test:firefox --workspace datastore-core,npm run test:firefox-webworker --workspace datastore-core: 284 passing eachElectron and the Windows/macOS matrix were not run locally. AI-assisted change.