fix(image): unfreeze H.264 playback on long-GOP and multi-stream recordings - #51
Merged
Merged
Conversation
…rdings Decoded frames were silently discarded once pipeline latency exceeded a 120ms output deadline, leaving the canvas stuck on the bootstrap frame with no error. Switch to newest-wins rendering, recover from degraded pressure under steady transport latency, and actively re-bootstrap when IDR recovery would otherwise wait forever on single-keyframe or 256-frame GOP streams.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
foxglove_msgs/msg/CompressedVideostreams (especially multi-camera 720p MCAP recordings with long GOPs or a single IDR).Root cause
The worker silently closed every decoded
VideoFrameoncereceiveTimelagged the playhead by more than 120ms. On six concurrent 720p streams the end-to-end latency is ~180–270ms, sorendered=0whiledroppedclimbed with no UI error.Test plan
npm run lintnpm test(692 passed)E45CF00A_1782467198053__1_3.mcapand_1_6.mcap