Repository navigation
feat(search): allow opting out of spotlight annotations - #238
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTP search currently requests optional Quipu annotations whenever an endpoint is configured. A search health probe therefore also invokes annotation work and can cancel it at the client deadline.
Add
spotlight=falseto omit only that annotation request. The default remains enabled; normal search retrieval, result validation and annotation response fields are preserved. Enabled calls send the stableX-Quipu-Client: bobbin-searchheader. Invalid boolean values refuse.Validation: actual binary compilation with
knowledgeand two focused query-parser/mock-HTTP controls PASS under the HOME guard (159 paths and five resources clean). The HTTP fixture observes zero calls when disabled and one attributed call with a retained annotation by default. Formatting, diff checks and all 85 documentation link checks PASS. Existing CI runs the full tests and Clippy with and withoutknowledge; those hosted gates remain pending. No full local suite or Clippy pass is claimed.Demo: retained test transcript and reproducer/limits. This is a synthetic loopback test transcript, not a video or installed monitoring proof.
The monitoring consumer will opt out only after a normal release supplies this flag. This PR does not publish a release, install a binary, modify monitoring configuration or establish a global timeout-alert recovery. Rollback is the normal source revert; the existing default remains compatible.