fix(eval): require explicit reasoning_effort for GLM-5.3+ - #59
Merged
Merged
Conversation
GLM-5.3-Flash silently defaults absent or unrecognized reasoning_effort to MAX; thinking.type=disabled is ignored there. The 2026-08-17 run measured reasoning mode at minutes per long paragraph, so a missing parameter turns a ~1h SadeedDiac-25 sweep into days. glm-5.3* models now refuse to start without an effort value; when given, both knobs are sent and reasoning_content in any response warns that the disable did not take. Checkpoints and the startup protocol line carry the effort level.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
GLM-5.3-Flash silently defaults
reasoning_effortto MAX when theparameter is absent or unrecognized — and
thinking: {"type": "disabled"}(the GLM-4.x/5.2 mechanism our eval uses) is exactly anunrecognized value there. Our 2026-08-17 GLM-5.2 reproduction
recorded reasoning mode at minutes per long paragraph; on the
1,200-paragraph SadeedDiac-25 sweep a missing parameter would turn a
~1h run into days — silently, with no error to catch.
What changes
eval_sadeed_glm.py(the only LLM API call site across rababa /ml-models / secryst / api — audited):
glm-5.3*models refuse to start without an explicit effortvalue:
python eval_sadeed_glm.py glm-5.3-flash lowreasoning_effort+thinking.type=disabled) so old and new models are coveredreasoning_contentprint a WARNING — atripwire proving the disable did not take
effort = different protocol = separate resume state) and the
startup protocol line, keeping decode-protocol disclosure intact
Verification
py_compileclean; refusal path exercised:python eval_sadeed_glm.py glm-5.3-flash→ exits with the messagethe Aug 17 reproduction that scored 2.5060 raw / 2.6911 zero-skip)
Notes
z.ai docs on the first real run; an invalid value also falls back
to MAX, which is why the response tripwire matters.
access) — retrying the leaderboard row is a separate decision.