fix: .parg gate to 283/285 — alias-stop guard and 4-hex \U escapes - #782
Merged
Merged
Conversation
The Ruby grammar's item_continuation checks (identifier ws? '=')- absent — without it the first alias value's concatenation swallowed the next alias declaration (srp_multichar = any([...]) ate srp_latupper...), failing six corpus maps (alalc-srp, bgnpcgn-rus-1947, bgnpcgn-srp-2005, din-grc, moct-kor, var-kor). Gate: 280/285.
The corpus converter emits \U040E-style escapes (gki-bel, mvd-bel, odni-bel); the Ruby grammar demanded 8 hex digits for \U and rejected the files. Accept 4..8 in both the DSL grammar and the .parg. Gate: 283/285 (remaining: un-mar has converter-corrupted escape output needing a maps-repo fix; odni-kor has a 2-element comment-parallel capture delta).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the .parg gate to 283/285 byte-identical trees (from 278).
Two grammar bugs the gate flushed out:
(identifier whitespace? "=")-absent — without it, the first alias value's concatenation swallowed the next alias declaration (srp_multichar = any([...])atesrp_latupper), which failed six corpus maps (alalc-srp, bgnpcgn-rus-1947, bgnpcgn-srp-2005, din-grc, moct-kor, var-kor-mr). One shared construct — six maps.\Uescapes demanded 8 hex digits; the corpus converter emits 4 ("\U040E", gki-bel/mvd-bel/odni-bel). The DSL grammar and the .parg now accept 4..8.Remaining 2 of 285:
un-mar-Deva-Latn-2016: converter-corrupted escape output in the corpus file itself (from some("\U") + "0939"— the escape split from its hex digits). Needs a maps-repo/converter fix, not a parser fix.odni-kor-Hang-Latn-2015: 2-element capture delta on comment-onlyparallel {}blocks.Full suite: 1149 examples, 0 failures with CI-equivalent flags. Artifact-path perf fix landed upstream (parsanol#160).