feat: kwargs directives through ISC — title_case word_separator, separate separator - #776
Merged
Merged
Conversation
…rate separator The grammar's string-case directive accepts an optional kwarg list after title_case; DocumentBuilder passes the kwargs through and the NodeAdapter forwards them into the Funcall. Isc::Generator emits separate/title_case with their kwargs. Also fixes the adapter's separate conversion: it emulated the directive as a space-to-separator substitution, which cannot produce the real semantics (join every codepoint with the separator) — a round-tripped separate silently did nothing on space-free input. It now builds a proper separate Funcall with the separator kwarg.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to interscript/interscript-py#7 (merge that first — CI clones interscript-python main).
What
title_caseaccepts an optionalword_separator: "…"kwarg (kwarg-list capture after the directive).string_caseitems into theFuncall.Isc::Generator: emitsseparate/separate separator "…"/title_case/title_case word_separator: "…".separatewas emulated as a space→separator substitution — which cannot produce the real semantics (こんいちは→こ|ん|い|ち|は, space-free input silently unchanged). It now builds a properseparateFuncall with the separator kwarg, matching the DSL/Stdlib behavior.Round-trip pinned in
generator_spec(behavior equality through the Interpreter, including both kwargs forms).With py#7: the dsl_stage Python directive legs go green (18 → 15 remaining failures locally, all in the any/alias/capture vocabulary cluster).